Open
Conversation
zhouwfang
force-pushed
the
zhoufang/iop-315-profile
branch
from
efd6d1b to
f8c6e94
Compare
bmwill
reviewed
Apr 10, 2026
Comment on lines
+131
to
+134
| let response_size = response.get_ref().encoded_len(); | ||
| let resp = RetrieveMessagesResponse::try_from(response.get_ref()) | ||
| .map_err(|e| tonic::Status::internal(e.to_string()))?; | ||
| Ok((resp, request_size, response_size)) |
Contributor
There was a problem hiding this comment.
If we want to add metrics to the clients/servers then we should leverage middleware as it will be much cleaner and keep the business logic free from this instrumentation.
You can take a look at MystenLabs/sui-rust-sdk#237 for how middleware can be added to grpc clients and https://github.com/bmwill/sui/blob/bf4f4c2e66964ba3668baa2accbf0521c9aa0e81/crates/sui-rpc-api/src/lib.rs#L229-L243 for how middleware can be added to the server side (I think we do already do some server side metrics using this paradigm.)
bmwill
reviewed
Apr 10, 2026
Comment on lines
+748
to
+751
| metrics | ||
| .mpc_dealer_crypto_duration_seconds | ||
| .with_label_values(&[MPC_LABEL_DKG]) | ||
| .observe(crypto_start.elapsed().as_secs_f64()); |
Contributor
There was a problem hiding this comment.
For timers we probably should use https://docs.rs/prometheus/latest/prometheus/struct.Histogram.html#method.start_timer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.